GPG sign downloader #7779
Open
GPG sign downloader #7779
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
force-pushed
the
gpg-sign-downloader
branch
from
7c128fa to
4cbd28f
Compare
faern
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion
installer-downloader/build.sh line 239 at r1 (raw file):
# GPG sign .dmg if [[ "$SIGN" != "false" ]]; then gpg_sign "$dmg_path"
This lives under the exact same condition as above. Is there any reason why we don't instead just call gpg_sign directly after notarize_mac in the if body above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DES-1804
This change is