Switch to ViewTransition API #7720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-jarvelov
force-pushed
the
switch-to-view-transition-api
branch
7 times, most recently
from
46b52f4 to
f259647
Compare
desktop/packages/mullvad-vpn/src/renderer/lib/transition-hooks.ts
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/test/e2e/installed/installed-utils.ts
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/test/e2e/installed/state-dependent/api-access-methods.spec.ts
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/test/e2e/installed/state-dependent/api-access-methods.spec.ts
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/test/e2e/installed/state-dependent/too-many-devices.spec.ts
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/test/e2e/installed/state-dependent/too-many-devices.spec.ts
Outdated
Show resolved
Hide resolved
tobias-jarvelov
force-pushed
the
switch-to-view-transition-api
branch
5 times, most recently
from
e69db40 to
e2a3d98
Compare
These will no longer be needed when we switch to the ViewTransition API for view transitions. It feels unnecessary to merge a suboptimal solution in the meanwhile.
As we have migrated to the native View Transitions API we can stop waiting for transitions to end manually. Playwright automatically waits for animations and elements to appear or disappear. As such, we don't have to manually wait for transitions to end in our tests.
- Replace use of regex in locators in favor of actual strings. - Use narrower locator for targeting connection action button.
This locator currently can be resolved to two elements. See: https://github.com/mullvad/mullvadvpn-app/actions/runs/13564177651/job/37914262416#step:9:985
This test is never run by the test-manager and can therefore be removed.
tobias-jarvelov
force-pushed
the
switch-to-view-transition-api
branch
from
e2a3d98 to
e9c05a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our custom built
TransitionContainer.tsxwith the JavaScript/CSS view transition API.Fixes DES-1405.
This change is