Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some debugging #52

Merged
merged 2 commits into from
Dec 8, 2022
Merged

add some debugging #52

merged 2 commits into from
Dec 8, 2022

Conversation

muir
Copy link
Owner

@muir muir commented Dec 8, 2022

Add a bit of debugging to help follow the flow of applying migrations.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 81.36% // Head: 81.28% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e9c4e51) compared to base (422d444).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   81.36%   81.28%   -0.08%     
==========================================
  Files          12       12              
  Lines        1191     1202      +11     
==========================================
+ Hits          969      977       +8     
- Misses        155      158       +3     
  Partials       67       67              
Flag Coverage Δ
go_tests 9.56% <0.00%> (-0.09%) ⬇️
mysql_tests 49.50% <54.54%> (+0.04%) ⬆️
pg_tests 54.03% <45.45%> (-0.10%) ⬇️
singlestore_tests 47.25% <27.27%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apply.go 83.20% <72.72%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

apply.go Outdated
return false, nil
} else {

Check warning

Code scanning / Revive (reported by Codacy)

if block ends with a return statement, so drop this else and outdent its block

if block ends with a return statement, so drop this else and outdent its block
@muir muir temporarily deployed to singlestore December 8, 2022 04:23 — with GitHub Actions Inactive
@muir muir merged commit f64702a into main Dec 8, 2022
@muir muir deleted the add-debug branch December 8, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants