Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SingleStore #26

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Add support for SingleStore #26

merged 3 commits into from
Oct 28, 2022

Conversation

muir
Copy link
Owner

@muir muir commented Oct 16, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 82.71% // Head: 81.36% // Decreases project coverage by -1.35% ⚠️

Coverage data is based on head (a4d9c18) compared to base (fa49111).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   82.71%   81.36%   -1.36%     
==========================================
  Files          11       12       +1     
  Lines        1018     1191     +173     
==========================================
+ Hits          842      969     +127     
- Misses        123      155      +32     
- Partials       53       67      +14     
Flag Coverage Δ
go_tests 9.65% <17.93%> (+1.60%) ⬆️
mysql_tests 49.45% <12.50%> (-7.23%) ⬇️
pg_tests 54.12% <0.00%> (-1.28%) ⬇️
singlestore_tests 47.43% <68.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lspostgres/postgres.go 78.18% <ø> (ø)
lssinglestore/singlestore.go 71.14% <71.14%> (ø)
lsmysql/mysql.go 78.70% <91.42%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir temporarily deployed to singlestore October 16, 2022 03:44 Inactive
@muir muir temporarily deployed to singlestore October 17, 2022 05:01 Inactive
@muir muir temporarily deployed to singlestore October 24, 2022 04:31 Inactive
@muir muir temporarily deployed to singlestore October 25, 2022 05:41 Inactive
@muir muir temporarily deployed to singlestore October 27, 2022 05:14 Inactive
@muir muir temporarily deployed to singlestore October 27, 2022 05:20 Inactive
@muir muir temporarily deployed to singlestore October 27, 2022 05:23 Inactive
@muir muir temporarily deployed to singlestore October 27, 2022 05:28 Inactive
@muir muir temporarily deployed to singlestore October 27, 2022 05:47 Inactive
@muir muir temporarily deployed to singlestore October 27, 2022 06:43 Inactive
@muir muir requested review from carlsverre and miccagiann October 27, 2022 19:56
Copy link
Collaborator

@miccagiann miccagiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship IT!

@muir muir merged commit 7e44bd3 into main Oct 28, 2022
@muir muir deleted the s2 branch October 28, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants