Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Fix next esm resolution #4745

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[code-infra] Fix next esm resolution #4745

wants to merge 4 commits into from
+15 −15

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 10, 2025 •
edited
Loading

Fix #4686 (comment)

Also moving the core peer dependency to latest beta as it will be required. (This is a breaking change)

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Mar 10, 2025
@mui-bot
Copy link

mui-bot commented Mar 10, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-4745--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against f2b698f

@Janpot Janpot marked this pull request as ready for review March 10, 2025 10:50
apedroferreira
apedroferreira approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had actually ran into this too but wasn't sure if this was the fix.

@apedroferreira
Copy link
Member

apedroferreira commented Mar 10, 2025 •
edited
Loading

Oh wait, I guess we need to update the versions for development, the playground apps and the examples accordingly?
And create-toolpad-app.
But I can take care of that.

@Janpot
Copy link
Member Author

Janpot commented Mar 10, 2025

Oh wait, I guess we need to update the versions

Yes, and I haven't tested what this does for Studio

@apedroferreira
Copy link
Member

Oh wait, I guess we need to update the versions

Yes, and I haven't tested what this does for Studio

Hopefully nothing too breaking, I'll try in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @apedroferreira