Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Modal][Dialog] Remove deprecated onBackdropClick #45395

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Feb 24, 2025

This prop has been deprecated since v4, it's time to remove it.

I don't think a codemod is possible, as it will be too dependent on onBackdropClick's function implementation.

@DiegoAndai DiegoAndai added breaking change component: dialog This is the name of the generic UI component, not the React module! component: modal This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Feb 24, 2025
@DiegoAndai DiegoAndai self-assigned this Feb 24, 2025
@mui-bot
Copy link

mui-bot commented Feb 24, 2025

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹✅

@DiegoAndai DiegoAndai merged commit 91938c8 into mui:master Feb 24, 2025
26 checks passed
@DiegoAndai DiegoAndai deleted the remove-onbackdropclick branch February 24, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: dialog This is the name of the generic UI component, not the React module! component: modal This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants