Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EnhancedButton] Make keyup event respect disableKeyboardFocus #3000

Merged
merged 1 commit into from
Jan 21, 2016

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 21, 2016

Signed-off-by: Junliang Huang [email protected]

@oliviertassinari
Copy link
Member

@JLHwung Good catch! 👍

@oliviertassinari oliviertassinari changed the title make enhanced button keyup event respect disableKeyboardFocus [EnhancedButton] Make keyup event respect disableKeyboardFocus Jan 21, 2016
oliviertassinari added a commit that referenced this pull request Jan 21, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
[EnhancedButton] Make keyup event respect disableKeyboardFocus
@oliviertassinari oliviertassinari merged commit 5d2d91a into mui:master Jan 21, 2016
@oliviertassinari
Copy link
Member

@JLHwung Thanks! I'm wondering why it was not like the _handleKeyDown in the first place.

@JLHwung
Copy link
Contributor Author

JLHwung commented Jan 21, 2016

@oliviertassinari Me, too. After checking the git history I thought it might be missing from some refactor so I add the pull request.

@JLHwung JLHwung deleted the fix-disableKeyboardFocus-keyup branch January 23, 2016 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants