Focus animations and labelPositions #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-cea
pushed a commit
that referenced
this pull request
Feb 2, 2015
Focus animations and labelPositions
|
Thanks @mmrtnz - looks great. |
zannager
added
the
package: styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches now support focusability and can be focused/changed via keyboard inputs. Animations are included to reflect when switches are focused. Refractoring was done so that rendering and event handling is done all through enhanced-switch. Styling from switch-wrap.less has been moved into enhanced-switched.less.
Also, all switches use the labelPosition prop (as opposed to labelPositionRight), including RadioButtonGroup.