Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ListItem] Nested items api changes #1438

Merged
merged 2 commits into from
Aug 19, 2015
Merged

[ListItem] Nested items api changes #1438

merged 2 commits into from
Aug 19, 2015

Conversation

hai-cea
Copy link
Member

@hai-cea hai-cea commented Aug 17, 2015

Breaking Changes
  • Nested list items are now explicitly passed in using the nestedItems prop instead of children.
  • The open prop has been renamed to initiallyOpen.

Fixes #1105

@hai-cea hai-cea mentioned this pull request Aug 17, 2015
Closed
@jkruder
Copy link
Contributor

jkruder commented Aug 17, 2015

@hai-cea Looks good to me.

@hai-cea hai-cea force-pushed the nested-list-api-change branch from 78c0651 to c50fd0a Compare August 19, 2015 16:05
@hai-cea hai-cea force-pushed the nested-list-api-change branch from c50fd0a to b92a1dd Compare August 19, 2015 16:15
hai-cea pushed a commit that referenced this pull request Aug 19, 2015
Merge pull request #1438 from hai-cea/nested-list-api-change
99389c0 
[ListItem] Nested items api changes
@hai-cea hai-cea merged commit 99389c0 into mui:master Aug 19, 2015
@hai-cea
Copy link
Member Author

hai-cea commented Aug 19, 2015

Thanks @jkruder

@hai-cea hai-cea deleted the nested-list-api-change branch August 21, 2015 20:35
@zannager zannager added the component: list This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ListItem] how to support SubItem
3 participants
@hai-cea @jkruder @zannager