Add timestamp to telegram events #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
reviewed
May 14, 2017
bees/telegrambee/telegrambee.go
Outdated
| @@ -116,6 +117,11 @@ func (mod *TelegramBee) Run(eventChan chan bees.Event) { | |||
| Type: "string", | |||
| Value: strconv.Itoa(update.Message.From.ID), | |||
| }, | |||
| { | |||
| Name: "timestamp", | |||
| Type: "string", | |||
There was a problem hiding this comment.
If we use unix timestamps here, we should treat the parameter as an integer as well. That being said, I think we actually wanna support handling timestamp as time.Time internally and let the conversion routine in placeholders.go do its magic (essentially make that support time.Time and let it convert from/to strings and integers).
rubiojr
force-pushed
the
timestamp-telegram-event
branch
from
04467ef to
196b3db
Compare
rubiojr
added a commit
to rubiojr/beehive
that referenced
this pull request
Apr 14, 2019
|
Now that you added a time format to Beehive, we could take another look at this! |
rubiojr
force-pushed
the
timestamp-telegram-event
branch
from
196b3db to
991e8d6
Compare
rubiojr
force-pushed
the
timestamp-telegram-event
branch
from
991e8d6 to
14d0c57
Compare
|
@muesli updated! |
muesli
requested changes
May 6, 2019
@muesli mentioned its internal Go type is separate to that type definition here, which we mostly use for the admin interface.
muesli
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor but useful thingie so we can use timestamps with action templates.