Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify semantics around uniffi_reexport_scaffolding! macro #2475

Open
mhammond opened this issue Mar 11, 2025 · 0 comments
Open

Clarify semantics around uniffi_reexport_scaffolding! macro #2475

mhammond opened this issue Mar 11, 2025 · 0 comments

Comments

@mhammond
Copy link
Member

Our docs talk about uniffi_reexport_scaffolding!, which links to rust-lang#50007, which is marked as "fixed". According to #1242, that was fixed in Rust 1.62, and we are way past that.

However, if I patch m-c to remove uniffi_reexport_scaffolding! I see undefined symbol errors for all our scaffolding functions. So it appears something remains necessary for symbols in other crates to be exported in the final library.

I bring this up because according to #2459, the code generated by this macro fails to build with Rust 2024 - instead of "fixing" that I was hoping we could just remove the capability entirely, but apparently we can not. Assume that's true, we should try and better document this work-around so we aren't blaming an issue that no longer exists.

mhammond added a commit to mhammond/uniffi-rs that referenced this issue Mar 11, 2025
As noted in mozilla#2459 and mozilla#2475, the `uniffi_reexport_scaffolding!` macro doesn't
work in Rust 2024.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant