Optimize for non-int and non-dup-sort types of databases using features #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorporof
force-pushed
the
clippy-to-string
branch
from
ab8ea2a to
d8f1d50
Compare
victorporof
force-pushed
the
db-type-features
branch
3 times, most recently
from
97d1fbc to
54f7123
Compare
victorporof
force-pushed
the
clippy-to-string
branch
from
d8f1d50 to
9b0c18f
Compare
victorporof
force-pushed
the
db-type-features
branch
2 times, most recently
from
2a6b7ae to
f34bb6e
Compare
Signed-off-by: Victor Porof <[email protected]>
Signed-off-by: Victor Porof <[email protected]>
victorporof
force-pushed
the
clippy-to-string
branch
from
9b0c18f to
3f50134
Compare
victorporof
force-pushed
the
db-type-features
branch
from
f34bb6e to
ea60010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Victor Porof [email protected]
Our current safe mode database implementation uses a
BTreeMap<Key, BTreeSet<Value>>to represent its data. This makes it so that we support theDUP_SORTdatabase flag inherited from LMDB, which in turn allows multi-stores.We don't use this in CRLite, so we'd incur a bit of overhead caused by the multiple levels of indirection. Making this distinction using the type system would either:
Store(Single | Multi)), orSimplest way around this is just using features.