Cow snapshots instead of always cloning #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorporof
force-pushed
the
cow-snapshots
branch
from
49ede8e to
9833144
Compare
victorporof
force-pushed
the
safe-arena
branch
from
467f6eb to
a0456db
Compare
victorporof
force-pushed
the
cow-snapshots
branch
from
9833144 to
62a1939
Compare
victorporof
force-pushed
the
safe-arena
branch
from
a0456db to
23d9f47
Compare
victorporof
force-pushed
the
cow-snapshots
branch
from
62a1939 to
17ed405
Compare
Signed-off-by: Victor Porof <[email protected]>
Signed-off-by: Victor Porof <[email protected]>
victorporof
force-pushed
the
safe-arena
branch
from
23d9f47 to
2a3dd18
Compare
victorporof
force-pushed
the
cow-snapshots
branch
from
17ed405 to
2bd0ab7
Compare
ncloudioj
reviewed
Nov 4, 2019
victorporof
added a commit
that referenced
this pull request
Nov 5, 2019
Cow snapshots instead of always cloning Signed-off-by: Victor Porof <[email protected]>
victorporof
added a commit
that referenced
this pull request
Nov 5, 2019
Cow snapshots instead of always cloning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To satisfy LMDB's semantics, querying or modifying individual transactions has certain behavior guarantees. Each transaction is a snapshot of the database; in other words, multiple read/write transactions are views into the database at the beginning of the transaction, altering or querying independent of each other.
To do this in safe mode, we create database snapshots when instantiating transactions (cloning on read). This is needlessly precautious, we can opt for cloning on write instead. This PR improves performance in case of large databases and the usual use of transactions.