wasapi: Speed up enumerate_devices by caching default device IDs for each flow/role instead of requerying for every wasapi_create_device. #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…each flow/role instead of requerying for every wasapi_create_device. Locally (on a machine with ~120 devices), this reduces a single enumerate_devices call from ~1100ms to ~250ms.
mutexlox-signal
added a commit
to mutexlox-signal/cubeb
that referenced
this pull request
Aug 30, 2024
Prior to mozilla#682, a device could be default for all of MULTIMEDIA, NOTIFICATION, and VOICE. After that PR, the first two were mutually exclusive with the third, I believe unintentionally. Restore this behavior so that, e.g., on devices with only one output device, querying for the "voice" device returns that device.
padenot
pushed a commit
that referenced
this pull request
Sep 6, 2024
Prior to #682, a device could be default for all of MULTIMEDIA, NOTIFICATION, and VOICE. After that PR, the first two were mutually exclusive with the third, I believe unintentionally. Restore this behavior so that, e.g., on devices with only one output device, querying for the "voice" device returns that device.
padenot
pushed a commit
to padenot/cubeb
that referenced
this pull request
Feb 13, 2025
Prior to mozilla#682, a device could be default for all of MULTIMEDIA, NOTIFICATION, and VOICE. After that PR, the first two were mutually exclusive with the third, I believe unintentionally. Restore this behavior so that, e.g., on devices with only one output device, querying for the "voice" device returns that device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally (on a i9-9900KS with ~60 input/~60 output devices), this reduces a single enumerate_devices call from ~1100ms to ~250ms.