Fixes 1139956 - Pressing links and controls doesn't highlight them #393
+124
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a nice side-effect of using the built-in gestures, things like long pressing on a phone number will also work much better. See https://www.dropbox.com/s/z5ubi6pwz4t0fzt/Screenshot%202015-04-28%2016.01.27.png?dl=0 |
|
Some questions/comments:
|
st3fan
force-pushed
the
st3fan/Bug1139956HighlightPressedLinks
branch
from
05073ff to
217d9e8
Compare
|
As per discussion: We keep the Add to Reading List item, but we point it our own. Also removed all traces of old |
st3fan
added a commit
that referenced
this pull request
Apr 29, 2015
…dLinks Fixes 1139956 - Pressing links and controls doesn't highlight them
ecotopian
referenced
this pull request
in ecosia/ios-browser
Mar 1, 2022
Improve the docs for the site #trivial
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disables our own long press gesture recognizer and disables the reading list option in the default WebKit action sheet.
The way this is implemented may look scary but this does not actually use private APIs. It simply uses the dynamic nature of Objective-C. The app store binary validator does not flag this as improper API usage.