Bug 1210109 menu #1721
Merged
Bug 1210109 menu #1721
+4,546
−928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffyemily
force-pushed
the
fluffyemily/Bug-1210109-Menu
branch
from
b61aa0e to
a20a1af
Compare
added 13 commits
April 20, 2016 18:07
- Create structs to describe MenuItems and MenuToolbarItems
- Create MenuConfiguration file
- Add test for menu configuration
- Create menu view
* create delegate and data source for menu toolbar items
* create delegate and data source for menu items
* adds a MenuItemView to a container view for each menu item
- Add custom Toolbar to provide rounded corners.
- Add footer view to menu view & use rounded toolbar for top right and top left
- Layout the title label to correct width
… more than 1 menu page
- Allow for configuration of max number of items in menu row,
- don't disable the menu button when the page is not a web page
- Ensure that menu is dismissed on rotation when in iPhone mode
- Present as popover correctly in ALL size classes
- make menu button user interaction enabled so that we can detect the touch and dismiss the menu
- ensure rounded corners of toolbar are shown by adding page control and collection view into container view
Bug 1210109 - Fix layout issue with menu (collection view height) in popover mode.
Always show home panel toolbar when menu available
- Move TabState protocol to struct and get Tab to return it's current state on request.
- Move AppState to be an enum that takes a state object (for tab) that also describes location
- Only store enum inside Menu and get MenuConfig to create itself based on state
- Keep track of menuController and update with new state when it changes
- Create HomePanelState and make home panels aware of whether it is in private or non-private mode.
- Add isPrivate method to app state rather than menuConfig. Create TabTrayState
- Turn MenuItem and MenuToolbarItem into protocols
- Turn MenuConfiguration into a protocol too, again for future proofing.
- Make TabStateDelegate an AppStateDelegate and make HomePanels, Tab Tray and Tab all keep a weak reference to it.
- Update app state when changes to state variables are made
- Only update the app state for the menu when the MOZ_MENU feature flag is enabled
Bug 1254574 & 1254575 - implement open in new normal & private tabs menu actions
Bug 1254586 - Implement Find In Page menu action
Bug 1254587 - Implement Request Desktop/Mobile site functionality
Bug 1254577 - Move bookmarks over to using TabState to make decisions.
* Implement Add/Remove Bookmark menu action
Bug 1254576 - implement open settings menu action
Bug 1254599 - Create all purpose animator for providing animations on menu items (or toolbar buttons if required)
Bug 1254577 - add selected state for add bookmark and implement a highlighted tint colour.
Bug 1263178 - Making it easier to generate URLs for opening the home panels
… the selected panel is switched rather than opening a new tab
- display menu instead of add tab button if menu enabled
- display always as popover in tabs tray (at least for as long as the menu button sits at the top.
- close only those tabs in the current tray (functionality checked and confirmed with @tecgirl)
* Updating Bookmarking tests to use menu bookmarks
* Add test for find in page from menu
* Add test to use desktop/mobile site switch from the menu
* Fix toolbar tests - look for menu button rather than bookmark button in toolbar
* Add menu specific tests
* Make MenuActions more generic in preparation for open sourcing
* Call performMenuAction asynchronously from menu rather than forcing the BVC to care about asynchronicty
* Better detect whether or not we are displaying home panels by checking the displayURL of the selected tab rather than whether or not there is a home panel controller
this is because a timing issue sometimes meant that the home panel controller from a previous tab was still hanging around when requesting a menu from a new tab with a URL, therefore displaying the wrong URL
* Only show settings button on tabs tray if not using menu
- When switching between private and non-private mode on home panels, update the isPrivate flag
- Make the menu button the right colour and positioned correctly
- separate the menu from the specific Browser implementation of it
- Make new custom UIBarButtonItems tappable
fluffyemily
force-pushed
the
fluffyemily/Bug-1210109-Menu
branch
from
a20a1af to
874f501
Compare
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Menu part of the exposing tools to the user story. The toolbar changes are under a separate story