Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-5166 Allow Database.command to run bulkWrite commands #2164

Merged
merged 3 commits into from
Feb 28, 2025
Merged

PYTHON-5166 Allow Database.command to run bulkWrite commands #2164

merged 3 commits into from
Feb 28, 2025

Conversation

ShaneHarvey
Copy link
Member

PYTHON-5166 Fix db.command bulkWrite bug

@ShaneHarvey ShaneHarvey changed the title PYTHON-5166 Fix db.command bulkWrite bug PYTHON-5166 Allow Database.command to run bulkWrite commands Feb 28, 2025
ShaneHarvey
ShaneHarvey commented Feb 28, 2025
View reviewed changes
pymongo/message.py
@@ -105,7 +105,7 @@
"insert": "documents",
"update": "updates",
"delete": "deletes",
"bulkWrite": "bulkWrite",
"bulkWrite": "ops",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a larger question here on if we should even be doing this behavior anymore at all but I'll open a new ticket to investigate that.

blink1073
blink1073 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShaneHarvey ShaneHarvey merged commit 080c1c6 into mongodb:master Feb 28, 2025
46 of 51 checks passed
@ShaneHarvey
Copy link
Member Author

drivers-pr-bot please backport to v4.11

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot
Copy link

Sorry, unable to cherry-pick to v4.11, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout -b cherry-pick-v4.11-080c1c61212594e4de4792cf055b904a570c4359 v4.11

git fetch origin 080c1c61212594e4de4792cf055b904a570c4359
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 080c1c61212594e4de4792cf055b904a570c4359
  1. You will likely have some merge/cherry-pick conflicts here, fix them and commit:
git commit -am {message}
  1. Push to a named branch:
git push origin cherry-pick-v4.11-080c1c61212594e4de4792cf055b904a570c4359
  1. Create a PR against branch v4.11. I would have named this PR:

"PYTHON-5166 Allow Database.command to run bulkWrite commands (#2164) [v4.11]"

ShaneHarvey added a commit to ShaneHarvey/mongo-python-driver that referenced this pull request Mar 3, 2025
@ShaneHarvey
PYTHON-5166 Allow Database.command to run bulkWrite commands (mongodb…
cac1be6 
…#2164)

(cherry picked from commit 080c1c6)
@ShaneHarvey ShaneHarvey mentioned this pull request Mar 3, 2025
Merged
ShaneHarvey added a commit that referenced this pull request Mar 3, 2025
@ShaneHarvey
PYTHON-5166 Allow Database.command to run bulkWrite commands (#2164) …
315f3cd 
…[v4.11] (#2172)
@ShaneHarvey ShaneHarvey deleted the PYTHON-5166 branch March 3, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneHarvey @blink1073