Limit to only artifacts that have updates and are in the dependency graph (#589) #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
requested changes
Aug 19, 2022
src/main/java/org/codehaus/mojo/versions/PluginUpdatesReport.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/PluginUpdatesReport.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/PluginUpdatesReport.java
Outdated
Show resolved
Hide resolved
src/test/java/org/codehaus/mojo/versions/PluginUpdatesReportTest.java
Outdated
Show resolved
Hide resolved
|
Please also change PR title and commit subject to something related with new features introduced in git. PR title will be in release notes. Commit it git history. |
andrzejj0
changed the title
andrzejj0
force-pushed
the
issue-589-pr
branch
from
467cab6 to
4f265ba
Compare
|
Review comments addressed. |
src/main/java/org/codehaus/mojo/versions/PluginUpdatesReport.java
Outdated
Show resolved
Hide resolved
src/test/java/org/codehaus/mojo/versions/DependencyUpdatesReportTest.java
Outdated
Show resolved
Hide resolved
andrzejj0
force-pushed
the
issue-589-pr
branch
2 times, most recently
from
74f5a83 to
7b774c0
Compare
src/main/java/org/codehaus/mojo/versions/DependencyUpdatesReport.java
Outdated
Show resolved
Hide resolved
…raph (mojohaus#589) Added `onlyUpgradable`, which will restrict the reports to only show upgradable artifacts, and `onlyProjectDependencies`, `onlyProjectPlugins`, which will restrict the graph of demendencyManagement/pluginManagement artifacts to the graph used in the project. Additionally, some refactoring and improvements.
andrzejj0
force-pushed
the
issue-589-pr
branch
from
7b774c0 to
f04c3ec
Compare
slawekjaranowski
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
onlyUpgradable, which will restrict the reports to only show upgradable artifacts, andonlyProjectDependencies,onlyProjectPlugins, which will restrict the graph of demendencyManagement/pluginManagement artifacts to the graph used in the project.Additionally, some refactoring and improvements.
Most importantly in class
AbstractVersionsReport, which redefined some of its superclass attributes in order to restrict access (?), which was apparently never used and could only create confusion. Simplified.