-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix progress managers episode 2 attack of the clones #156
Open
mdr223
wants to merge
26
commits into
dev
Choose a base branch
from
fix-progress-managers-episode-2-attack-of-the-clones
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,963
−2,136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
optimizer-demo.py
dataclasses.py
ExecutionStats
by more explicitly declaringsentinel_plan_stats
(rather than grouping plan stats and sentinel plan stats together in the same dict)filters.py
records.py
field_to_score_fn
toDataRecordSet
to make it easier to access for target records in sentinel executionexecution_strategy.py and execution_strategy_type.py
ExecutionStrategyType
to its own fileSentinelExecutionStrategyType
ExecutionStrategy
SentinelExecutionStrategy
SentinelExecutionStrategy
for scoring computed recordsscore_quality
andcompute_quality
mab_execution_strategy.py and random_sampling_execution_strategy.py
mab_sentinel_processor.py
andrandom_sampling_sentinel_processor.py
, but refactored a bitparallel_execution_strategy.py and single_threaded_execution_strategy.py
_execute_plan()
method so that progress manager could be stopped no matter what if there was an exception thrown during executioncost_model.py
SampleBasedCostModel
to process aSentinelPlanStats
object (rather than some bespoke dictionary)optimizer.py
**config.to_dict()
in query processor factoryoptimizer_strategy.py and optimizer_strategy_type.py
tasks.py
OptimizerStrategyType
config.py
*_type
variablesmab_sentinel_processor.py and random_sampling_sentinel_processor.py
nosentinel_processor.py
QueryProcessor
takes anexecution_strategy
query_processor.py
execution_strategy
andsentinel_execution_strategy
query_processor_factory.py
optimizer
,execution_strategy
, andsentinel_execution_strategy
and feed them into the processor constructorsentinel_processor.py
MABSentinelProcessor
andRandomSamplingSentinelProcessor
progress.py