Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a TimestepValue offset indexing bug #857

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Conversation

davidanthoff
Copy link
Collaborator

No description provided.

@davidanthoff davidanthoff requested a review from lrennels October 19, 2021 22:47
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #857 (0544445) into master (b74d386) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files          40       40           
  Lines        3792     3792           
=======================================
  Hits         3197     3197           
  Misses        595      595           
Flag Coverage Δ
unittests 84.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/time_arrays.jl 93.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74d386...0544445. Read the comment docs.

lrennels
lrennels previously approved these changes Oct 20, 2021
Copy link
Collaborator

@lrennels lrennels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests

@lrennels lrennels merged commit f3382b5 into master Oct 20, 2021
@lrennels lrennels deleted the timestepvalue-offset-fix branch October 20, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants