using renamed components in #defcomposite

[lrennels]

#686

[codecov]

Codecov Report

Merging #698 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   79.16%   79.20%   +0.03%     
==========================================
  Files          39       39              
  Lines        2851     2851              
==========================================
+ Hits         2257     2258       +1     
+ Misses        594      593       -1     

Flag	Coverage Δ
#unittests	79.20% <100.00%> (+0.03%)	⬆️

Impacted Files	Coverage Δ
src/core/defcomposite.jl	82.27% <100.00%> (+1.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5498b...41fee79. Read the comment docs.

[corakingdon]

I think this error will also need to be addressed not just for Parameter statements but also Variable statements and connect statements. Here's an expanded example to hit all three:

@defcomp A begin
    p1 = Parameter()
    p2 = Parameter()

    v1 = Variable()
end

@defcomp B begin
    v2 = Variable()
end

@defcomposite C begin

    foo = Component(A)
    bar = Component(B) 

    rename_p1 = Parameter(foo.p1) 

    connect(foo.p2, bar.v2)

    rename_v1 = Variable(foo.v1)
end

[lrennels]

@ckingdon95 the macro yields the following with the @defcomposite C call (in a let block but I removed that for now)

cc_id = Mimi.ComponentId(Main, :C)
obj = Mimi.CompositeComponentDef(cc_id)

#= /Users/lisarennels/.julia/dev/Mimi/src/core/defcomposite.jl:183 =#
global C = obj

#= /Users/lisarennels/.julia/dev/Mimi/src/core/defcomposite.jl:184 =#
Mimi.add_comp!(obj, A, :foo)
Mimi.add_comp!(obj, B, :bar)
Mimi.import_param!(obj, :rename_p1, obj[:foo] => :p1; )
Mimi.connect_param!(obj, :foo, :p2, :bar, :v2; )
Mimi._import_var!(obj, :rename_v1, ComponentPath(:foo,), :v1)

#= /Users/lisarennels/.julia/dev/Mimi/src/core/defcomposite.jl:185 =#
Mimi.import_params!(obj)

#= /Users/lisarennels/.julia/dev/Mimi/src/core/defcomposite.jl:186 =#
C

[lrennels]

Note from conversation: This macro expand looks good, next step is to move the wip file to testing, perhaps test for keys like:

@test (:foo, :bar, :rename_p1, :rename_v1) in keys(C.namespace)