Fix bug in add_connector_comps on master #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrennels
changed the title
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
+ Coverage 80.21% 80.22% +<.01%
==========================================
Files 39 39
Lines 2745 2746 +1
==========================================
+ Hits 2202 2203 +1
Misses 543 543
Continue to review full report at Codecov.
|
corakingdon
approved these changes
Jan 27, 2020
|
@lrennels agreed we should just merge this even though it can't fully be used in this state, it's still a bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#646 This PR fixes a bug in the
add_connector_comps!function on master, where we have currently disabled functionality surrounding components with different lengths ... but this is a bug we will want to track and fix anyways unless we remove the function all together. I'd suggest merging this fix for now.