Fix param exports #579
Merged
Fix param exports #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…composites (not just ModelDefs) - Removed function import_params! - Added function propagate_params! - Added call to propagate_params! to code emitted by @defcomposite, now exporting only unconnected params. - Deprecated old function name() in favor of nameof().
corakingdon
reviewed
Oct 16, 2019
There was a problem hiding this comment.
Looks good to me! I trust you tried this out with the reverted version of FUND you created? (fund-model/MimiFUND.jl#53)
Since the dependency tests that are running here are still using the version where the population component's name was changed right?
lrennels
approved these changes
Oct 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 77.39% 77.49% +0.09%
==========================================
Files 39 39
Lines 2584 2573 -11
==========================================
- Hits 2000 1994 -6
+ Misses 584 579 -5
Continue to review full report at Codecov.
|
|
@rjplevin shall I merge this? |
|
Sure, once the checks complete... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopped exporting connected params, and added a call to the new function
propagate_params!()to the code emitted by@defcomposite.