Change getindex to getdataframe for sim_inst #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjplevin
reviewed
Oct 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 77.42% 77.39% -0.03%
==========================================
Files 39 39
Lines 2583 2584 +1
==========================================
Hits 2000 2000
- Misses 583 584 +1
Continue to review full report at Codecov.
|
rjplevin
previously approved these changes
Oct 15, 2019
corakingdon
reviewed
Oct 15, 2019
|
@davidanthoff I'm getting PyCall errors in this Travis build, any advice? I tried closing and opening the PR but got the same error. |
corakingdon
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles Issue #572.
Remove the
getindexmethod forSimulationInstanceand replace it withgetdataframe. Users will be able to usegetdataframeto access results of a simulation while we do some thinking on what type we'd likegetindexto return and how to handle the multidimensionality of scenarios etc.