-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Doctests #557
Merged
Merged
Use Doctests #557
Changes from 2 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
b7e3adf
Start including doctests
lrennels 4fbffd7
Add doctests to faq
lrennels 76c95d4
Add continuous doctest scope; improve consistency of docs
lrennels 59efb5c
Add doctests to testing suite
lrennels c4bdefa
Debug doctests
lrennels 42d64e0
Fix typo
lrennels be5eec4
add blank lines after output
lrennels 878ecd4
Debug doctests, tests passing
lrennels 40f9edd
Add doctests to tutorial 3
lrennels e8a2fa5
mege master
lrennels 8d14a3c
Add Project.toml packages; add doctests to Tutorial 1
lrennels 0760c0f
Add more doctesting
lrennels 234b02f
Clean up doctests; all tests passing
lrennels 994a2d4
Merge branch 'master' into doctests
lrennels 573322c
Merge branch 'master' into doctests
lrennels 9735f57
start updating tutorial 4
corakingdon 11b355d
Merge branch 'doctests' of https://github.com/mimiframework/Mimi.jl i…
corakingdon ec8373c
Update Documenter version
lrennels 0c4f2dc
Merge branch 'doctests' of https://github.com/mimiframework/Mimi.jl i…
lrennels a43f1b1
Merge branch 'master' into doctests
lrennels 306ba46
Use setdocmeta! per v0.23 breaking change
lrennels 62183c0
Merge branch 'master' into doctests
lrennels 4c257fe
Merge branch 'master' into doctests
lrennels 136b0a7
Add using statements to docstrings; metadata not working
lrennels 14d6512
Add compat for Documenter
lrennels af24d03
Remove Documenter from compat
lrennels 90dfead
Merge branch 'master' into doctests
lrennels dee6c54
remove include statement from tutorial 4
corakingdon 24627a8
conclude merge
corakingdon f4ce868
Remvoe doctest from runtests.jl file
lrennels ec563fa
updates to tutorial_main
corakingdon 2841be9
fix spacing in compdefs
corakingdon 71f9537
rename two-region-model to multi-region-model
corakingdon 9be6f9b
Start updating tutorial 4
corakingdon 150f9ad
Merge branch 'doctests' of https://github.com/mimiframework/Mimi.jl i…
corakingdon a15233a
more edits to tutorial 4
corakingdon f7f7f00
Various updates to doctests
lrennels 47a411f
Use Julia 1.2 for doc build
davidanthoff e07ee03
Tweak travis script
davidanthoff 57b679d
Fix travis
davidanthoff 165b937
Include newlines in filters; fix bug
lrennels ee38231
small edits to tutorials 1 and 2
corakingdon 771692d
Merge branch 'master' into doctests
lrennels 643adb5
Fix doctest; udpate reference.md
lrennels 94bc5c3
remove doctest filter on one block
corakingdon 6853786
Try running doctests from make.jl
lrennels 7bbb36d
Merge master
lrennels 8570ae8
Update FUND version
lrennels 95371d0
Fix typo; Add filter to supress deprecation warnings
lrennels 75e0c07
Fix typo
lrennels 808df07
Add missing docstrings for reference.md
lrennels a890f7c
Fix typo
lrennels b4f7039
Use getdataframe for simulation instance
lrennels 0f3e340
Remove explicit doctest call from make.jl
lrennels da02eec
Test that Travis doctests fail
lrennels c9be343
Merge branch 'doctests' of https://github.com/mimiframework/Mimi.jl i…
lrennels 47d55e9
Add test to see if Travis will fail doctestS
lrennels bc7e8d6
Remove bug tests.
lrennels 0a137d1
Change makedocs strict setting to true
lrennels 37f7820
Merge branch 'doctests' of https://github.com/mimiframework/Mimi.jl i…
lrennels a3771be
Move doctesting to outside of makedocs
lrennels b72afbd
Fix minor typos
corakingdon 7bcb1a7
Remove uncessary compats from docs Project.toml
corakingdon 0d784be
Remove MimiFUND compat in docs
corakingdon 9331ef4
Move `doctest(Mimi)` into test suite
corakingdon 77f0330
Fix doctest setup
corakingdon b170208
Merge branch 'master' into doctests
lrennels 9ad3547
Update travis.yml file
lrennels 01ef1fa
missing quote
corakingdon e4b0b96
Move doctest to botto of testing suite file
lrennels 4f478cf
Merge branch 'doctests' of https://github.com/mimiframework/Mimi.jl i…
lrennels 2902d7d
Remove doctesting of explore function
lrennels 04d54ab
Add # output line to fix bug
lrennels 12af5e2
Merge branch 'master' into doctests
davidanthoff 723a3aa
Move doctest call
davidanthoff 7198310
Add MimiRegistry in build on gh
davidanthoff cc8e704
Try new strategy for package install
davidanthoff f793174
Fix bug in Project.toml
davidanthoff 6fb320a
Fix a doctest bug
davidanthoff 473ff22
Rearrange some code
davidanthoff b7f62ab
Merge branch 'master' into doctests
davidanthoff 40cdff3
Merge branch 'master' into doctests
davidanthoff a570d75
Doctest dataframes instead of arrays
lrennels 17c17f7
Merge branch 'doctests' of https://github.com/mimiframework/Mimi.jl i…
lrennels f8010bc
Merge branch 'master' into doctests
lrennels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
[deps] | ||
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f" | ||
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||
Mimi = "e4e893b0-ee5e-52ea-8111-44b3bdec128c" | ||
|
||
[compat] | ||
Distributions = "0.21" | ||
Documenter = "~0.21" | ||
Mimi = "0.9.3" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be Mimi 0.9.4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or actually wouldn't we need it to be the 0.9.5-dev version? I guess this is a broader question I have about whether or not our documentation is supposed to be compatible with the latest released version, or with master. I think that the version of documentation that lives on https://www.mimiframework.org/Mimi.jl/stable/ only shows the documentation for the latest released version right? So that means we should always have our documentation up to date with master, but it won't actually display until a new release of Mimi happens?
If all of that is true, then I think the version of Mimi that we want in the Project.toml would be master, but I'm not sure how to specify that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the version of the documentation that lives in the
stable
link only shows documentation for the latest tagged/released version of Mimi, so the documentation might as well keep up with master. I think 0.9.4 is probably good enough but I guess eager would be idea? @davidanthoff?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should remove all entries other than
Documenter
itself from here. Documenter should be specified as~0.23
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the
~
mean? I think we also need to keep MimiFUND at at least3.11.9
, so would that also need to beMimiFUND = "~3.11.9"
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://julialang.github.io/Pkg.jl/v1/compatibility/#Caret-specifiers-1
So I actually think it doesn't matter whether we use caret or tilde for
Documenter
, we should just specify one of them.For FUND, if there is a minimal version we require we can just say
MimiFUND = "3.11.9"
. But do we need that? It will just grab the latest version if we don't specify anything, which is what we want, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but for FUND, I think we should actually not use the tilde operator, otherwise we potentially pin FUND to old versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we shouldn't have to specify FUND then. But why do we have to specify for Documenter then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They might release a breaking release, and we would want to opt in to get that.