Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in dotview() for timesteps #513

Merged
merged 2 commits into from
May 31, 2019
Merged

Fix bug in dotview() for timesteps #513

merged 2 commits into from
May 31, 2019

Conversation

rjplevin
Copy link
Collaborator

Fix bug in dotview() for timesteps and added preliminary example sent by James as test/test_broadcast.jl (not fully wired into testing system yet...)

Add preliminary example sent by James as test/test_broadcast.jl
@rjplevin rjplevin requested a review from davidanthoff May 28, 2019 16:31
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #513 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   80.82%   80.83%   +<.01%     
==========================================
  Files          26       26              
  Lines        1935     1936       +1     
==========================================
+ Hits         1564     1565       +1     
  Misses        371      371
Impacted Files Coverage Δ
src/core/time.jl 82.96% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03d112...8cf892b. Read the comment docs.

- Integrated test_broadcast.jl into test system
Copy link
Collaborator

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the whole dotview/broadcasting API, so can't really review this. BUT, if it works, lets merge it!

@rjplevin
Copy link
Collaborator Author

Ok -- it doesn't seem to break anything, and James hasn't declared it broken, so I'll merge.

@rjplevin rjplevin merged commit 2183836 into master May 31, 2019
@rjplevin rjplevin deleted the dotview-fix branch May 31, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants