Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sim modification functions to userguide #501

Merged
merged 3 commits into from
May 24, 2019
Merged

Add sim modification functions to userguide #501

merged 3 commits into from
May 24, 2019

Conversation

lrennels
Copy link
Collaborator

No description provided.

@lrennels lrennels requested a review from rjplevin May 23, 2019 23:27
Copy link
Collaborator

@rjplevin rjplevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to export all of these? I think these functions will be used by relatively few users.

@lrennels
Copy link
Collaborator Author

lrennels commented May 23, 2019

@rjplevin we probably don't, you're right and I was thinking about that, but wanted to link to the docstrings in which case I needed them in the Reference.md file. I guess it would be better to unlink them in the docs and the users can look them up if they want them.

I realized in the meantime that our Reference.md file isn't building properly ...

@lrennels
Copy link
Collaborator Author

Ah I think I found the problem there looking at the v0.9.0 docs build ... it can't the new_comp doctstring

@codecov-io
Copy link

Codecov Report

Merging #501 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   80.74%   80.74%           
=======================================
  Files          26       26           
  Lines        1937     1937           
=======================================
  Hits         1564     1564           
  Misses        373      373
Impacted Files Coverage Δ
src/Mimi.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a5454...70a2265. Read the comment docs.

@lrennels lrennels requested a review from rjplevin May 24, 2019 00:53
@lrennels lrennels merged commit e722e4c into master May 24, 2019
@lrennels lrennels deleted the docs branch May 24, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants