Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why different version control display between windowed and tty ? #123

Open
deb0ch opened this issue May 26, 2016 · 2 comments
Open

Why different version control display between windowed and tty ? #123

deb0ch opened this issue May 26, 2016 · 2 comments

Comments

@deb0ch
Copy link
Contributor

deb0ch commented May 26, 2016

Why is there a different display of version control in tty mode and gui mode ?

The one on gui mode (using the variable vc-mode) is more compact and bears more information than the tty version using vc-working-revision.

What was particularly annoying me was that vc-working-revision displayed the full SHA-1 and took way too much space.

I modified it locally to use (format-mode-line '(vc-mode vc-mode))) instead for my own convenience and it works just fine.

Are you interested in a pull request ?

@milkypostman
Copy link
Owner

Pull request is the only way things will get changed. I am not longer
"maintaining" this package.
On Thu, May 26, 2016 at 05:02 Thomas de Beauchêne [email protected]
wrote:

Why is there a different display of version control in tty mode and gui
mode ?

The one on gui mode (using the variable vc-mode) is more compact and
bears more information than the tty version using vc-working-revision.

I modified it locally to use (format-mode-line '(vc-mode vc-mode)))
instead for my own convenience and it works just fine.

Are you interested in a pull request ?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#123

@deb0ch
Copy link
Contributor Author

deb0ch commented May 26, 2016

Just wondering if there was any particular reason.

Apparently vcs is handled a different way in tty or gui modes since Thu Mar 12 20:42:19 2015, when you added a UTF-8 char only in tty mode. In this commit (f4c831e) you also introduced a check for the presence of a backend.

I just want to make sure that I will not break anything if I submit a commit using the UTF-8 char and the vc-mode variable (which would display Git:f4c831e1) instead of vc-working-revision (which would display f4c831e1997e8fac2069e737d5d8d27201320067) the exact same way in gui and tty modes. Or that gui users won't be angry of seeing a new UTF-8 char in their powerline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants