Nudge users towards sign-in

[isidorn]

Currently 31% of users that have GH PR extension installed in VS Code are NOT logged in to GitHub. Thus they are missing on all the great GH PR extension functionality. This is a large number and we need to look into product changes on the extension side to better nudge users towards sign-in.

One of the simple first steps is to show a badge in the accounts menu when the user is not signed in after installing the GH PR extension.

@alexr00 you probably have better ideas :) You also shared that historically we did not do this for the vscode.dev flow so users would not get a lot of badges on the Account menu when they open it for the first time. However since majority of GH PR extension is in VS Code desktop we should gear the experience towards that.

fyi @joaomoreno

[alexr00]

One of the simple first steps is to show a badge in the accounts menu when the user is not signed in after installing the GH PR extension.

I would definitely start here. We could also show a badge on the "GitHub" activity bar icon, which is even more visible than the Accounts menu.

[isidorn]

Agreed. Let's start with the accounts menu. We see how it affects numbers and then we can decide on next steps?

[alexr00]

To start with, we can just show the accounts menu badge on desktop if we don't want to do so everywhere.

[isidorn]

Let's see what @joaomoreno thinks about the vscode.dev experience. Do you remember who was previously pushing for this experience in vscode.dev, so we also include them in this discussion.

[joaomoreno]

The thought of not showing the account badge notification by default on https://vscode.dev is still an honorable one. If it's likely that the user would benefit from being logged in to GH on GHPRI, chances are that they already came into the workbench via https://vscode.dev/github/foo/bar, thus they are already logged in via OAuth.

That being said, showing a (1) in Accounts makes sense in the Desktop, other smaller extensions do it:

Screen.Recording.2023-04-24.at.16.03.32.mov