Error early on --build #926
Merged
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
DanielRosenwasser,
andrewbranch,
iisaduan and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an early check for build mode commands, providing a clearer error message instead of a cryptic failure later in processing.
- Introduces an early branch that detects build mode flags in the first command line argument.
- Prints a user-friendly message and exits with a not implemented status when a build mode flag is detected.
DanielRosenwasser
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit less cryptic than "error TS6369: Option '--build' must be the first command line argument.", which only shows up because we don't yet have build mode code that checks the first arg.