Unconditionally set dirtyFilePath in markAsDirty #886
Merged
+70
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabritto
approved these changes
May 20, 2025
| if !project.deferredClose { | ||
| project.pendingReload = PendingReloadFull | ||
| project.markAsDirty() | ||
| } | ||
| project.updateIfDirty() |
There was a problem hiding this comment.
Seems to me this shouldnt be called here and should either send notification to client that things have changed and/or update on next request ?
There was a problem hiding this comment.
I think we’ll need this because we’ll have to do push diagnostics for config file errors, which aren’t hooked up yet, but I think we could do that for now. I think I’d like to do that in a separate PR though, as this one is just trying to prove that there was a bug and fix it. We’re trying to get things stable for an npm release.
| project.markAsDirty() | ||
| if project.kind == KindAutoImportProvider || project.kind == KindAuxiliary { | ||
| return | ||
| project.updateGraph() |
jakebailey
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug caught by @gabritto in https://github.com/microsoft/typescript-go/pull/879/files/a30a84c490a5d49555a8f46b1516836b75c560e8#r2098483287.
I had to make the other changes in order to make the test fail; there was an unnecessary double update on config file changes that was clearing out the dirty state on the second update.