Create preview builds for publishing to npm and VS Code marketplace #876
+1,726
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Rosenwasser <[email protected]>
andrewbranch
approved these changes
May 21, 2025
RyanCavanaugh
approved these changes
May 21, 2025
jakebailey
commented
May 21, 2025
Comment on lines
+989
to
+992
| `# \`${npmPackageName}\``, | ||
| "", | ||
| `This package provides ${nodeOs}-${nodeArch} support for [${packageJson.name}](https://www.npmjs.com/package/${packageJson.name}).`, | ||
| ]; |
There was a problem hiding this comment.
This is a placeholder; I don't think we need any more than this but let me know.
jakebailey
commented
May 21, 2025
Co-authored-by: Daniel Rosenwasser <[email protected]>
Sainan
reviewed
Jun 21, 2025
| "type": "module", | ||
| "preferUnplugged": true, | ||
| "engines": { | ||
| "node": ">=20.6.0" |
There was a problem hiding this comment.
What's the reasoning behind selecting this restriction here?
There was a problem hiding this comment.
For unflagged and sync import.meta.resolve, and Node 18 is EOL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of infrastructure to produce preview npm packages and VS Code extensions.
At a high level, users will be able to
npm install @typescript/native-preview, then donpx tsgoto try out the CLI. The CLI is not calledtscto prevent conflicts at this stage.There will be an extension "TypeScript (Native Preview)" published to the VS Code marketplace to be able to try out the language server implementation.
Eventually, these will all be marked as deprecated and users will be able to use the real deal (whenever we're "done" and move the codebase over).
This all requires building the package for a slew of platforms, binary signing, and so on. It's a bit challenging to put together and test out, but I think it should work at this point. I am explicitly not building for every platform Go supports (what esbuild does), but rather starting out building for all platforms VS Code supports. That should be sufficient for now.
TODO:
tsdkloading reasons.