Fix LSP line/pos at start of a line #866
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the calculation of the line and character positions for LSP by adjusting how the line start is determined when the given position is not at the beginning of a line.
- Adjusts the line detection logic in PositionToLineAndCharacter by detecting if the position is at a line start and decrementing the line index if not.
- Ensures that the line value does not become negative with a max(0, line) clamp.
Comments suppressed due to low confidence (1)
internal/ls/converters.go:242
- Consider adding tests to cover edge cases for this conversion logic, such as when the position coincides with the start of a line and when it does not.
line, isLineStart := slices.BinarySearch(lineMap.LineStarts, position)
gabritto
approved these changes
May 14, 2025
|
Yep, works:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
We really need tests for this conversion but this should be sufficient to fix this for demo purposes.
Probably fixes the global completions PR?