Properly visit the Expression node of a TypeParameterDeclaration
#865
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a crash in the language service when processing a type parameter with an incomplete "extends" clause.
- Added a visit call for the Expression node in the TypeParameterDeclaration to prevent crashes.
- Ensured consistency in node visits by extending the pattern used in existing nodes.
jakebailey
reviewed
May 14, 2025
internal/ast/ast.go
Outdated
| @@ -2084,7 +2084,7 @@ func (f *NodeFactory) UpdateTypeParameterDeclaration(node *TypeParameterDeclarat | |||
| } | |||
|
|
|||
| func (node *TypeParameterDeclaration) ForEachChild(v Visitor) bool { | |||
| return visitModifiers(v, node.modifiers) || visit(v, node.name) || visit(v, node.Constraint) || visit(v, node.DefaultType) | |||
| return visitModifiers(v, node.modifiers) || visit(v, node.name) || visit(v, node.Constraint) || visit(v, node.DefaultType) || visit(v, node.Expression) | |||
There was a problem hiding this comment.
I think this actually needs to come before DefaultType, given where the parser parses it.
jakebailey
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing
visit(v, node.Expression)caused a crash in the language service for a type parameter with an incompleteextendsclause.