Skip to content

Further test and fix compiler options #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

jakebailey
Copy link
Member

Following from #853.

I'm not sure whether or not ModuleKind was intended but I assume not?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the naming of the compiler options by renaming properties from "ModuleKind" to "Module" and "moduleDetectionKind" to "moduleDetection" across baselines, tests, and internal implementation.

  • Renames JSON keys and struct fields to improve consistency
  • Updates tests and parsing helpers to reference the new property names

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/baselines/reference/tsc/commandLine/Parse-enum-type-options.js Replaced "moduleDetectionKind" with "moduleDetection" in baseline output
testdata/baselines/reference/config/tsconfigParsing/parses tsconfig with compilerOptions, files, include, and exclude with jsonSourceFile api.js Updated JSON key "moduleDetectionKind" to "moduleDetection"
testdata/baselines/reference/config/tsconfigParsing/parses tsconfig with compilerOptions, files, include, and exclude with json api.js Updated JSON key "moduleDetectionKind" to "moduleDetection"
internal/tsoptions/tsconfigparsing_test.go Adjusted field name from "ModuleKind" to "Module" in expected CompilerOptions comparisons
internal/tsoptions/parsinghelpers.go Updated property access from "ModuleKind" to "Module" when parsing compiler options
internal/transformers/esmodule_test.go Updated tests to use "Module" instead of "ModuleKind" for compiler options
internal/transformers/esmodule.go Updated member access to use "Module" in export declaration logic
internal/transformers/commonjsmodule_test.go Updated test compiler options to assign "Module" for CommonJS modules
internal/core/compileroptions.go Revised JSON tag and field name from "ModuleKind" to "Module", and from "moduleDetectionKind" to "moduleDetection"
internal/binder/binder_test.go Updated test initialization to reference "Module" rather than "ModuleKind"

@jakebailey jakebailey added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit f822b4d May 8, 2025
23 checks passed
@jakebailey jakebailey deleted the jabaile/further-test-compiler-options branch May 8, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants