Skip to content

add a couple of missing options to be parsed #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

srabraham
Copy link
Contributor

@srabraham srabraham commented Apr 30, 2025

As things are, tsgo basically ignores these fields in a tsconfig, so rewriting imports doesn't work.

Could there be a "default: panic" or similar in this switch? Or some test? That'd presumably help make this kind of bug less easy to come up again.

EDIT: This PR is mutually incompatible with my other one, #839. If #839 makes sense, I suggest you merge that one and close #838.

Verified

This commit was signed with the committer’s verified signature.
srabraham Sean R. Abraham
As things are, tsgo basically ignores these fields in my tsconfig.

Could there be a "default: panic" or similar in this switch? That'd
presumably help make this kind of bug less easy to come up again.
@jakebailey
Copy link
Member

jakebailey commented May 7, 2025

I think I'd prefer #839, or at least some other test for this.

@jakebailey jakebailey closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants