Skip to content

Remove old parser clears #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Remove old parser clears #827

merged 1 commit into from
Apr 28, 2025

Conversation

jakebailey
Copy link
Member

These are no longer needed, given putParser clears everything out.

@jakebailey jakebailey requested review from sandersn and Copilot April 25, 2025 22:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up redundant parser state reset lines in favor of relying on putParser to clear the parser's state.

  • Removed explicit reset of p.hasParseError in initializeState.
  • Removed resetting of p.jsdocCache and possibleAwaitSpans in parseSourceFileWorker.
  • Removed resetting of p.jsdocCache and p.identifiers in finishSourceFile.

@jakebailey jakebailey added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 3978f50 Apr 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants