Skip to content

Add ability to build extension VSIX and swap for built-in extension #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2025

Conversation

andrewbranch
Copy link
Member

This PR sets up a hereby command to build and persistently install the tsgo VS Code extension. It does nothing if the default typescript-language-features extension is active. microsoft/vscode#246858 allows for disabling that one via configuration/command, allowing the tsgo LSP to take over. Also adds a warning-colored status bar item to make it obvious when you’re running tsgo instead of stable TypeScript in the editor.

Screen.Recording.2025-04-17.at.12.27.57.PM.mov

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 21:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the ability to build and install the tsgo VS Code extension while overriding the built-in TypeScript extension when needed, and it adds a warning-colored status bar item to signal the active tsgo mode.

  • Adds a status bar item and associated quick pick menu for extension commands.
  • Implements logic to skip activation when the built-in TypeScript extension is active and configuration dictates.
  • Updates the Herebyfile to include an insiders option for extension installation.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

File Description
_extension/src/extension.ts Introduces status bar integration, command registration, and modified activation/deactivation logic.
README.md Updates instructions to reflect the new extension build and installation steps.
Herebyfile.mjs Adds an insiders flag and implements a new task to build and install the extension.
Files not reviewed (1)
  • _extension/package.json: Language not supported

@jakebailey
Copy link
Member

Ah, seems like you have the npm bug that Kat fixed; probably want to restore your lockfile to main, delete all node_modules, and then install again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What in the heck is vsce doing with 5000 lines of deps added???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J***** ******d 🥲

@andrewbranch andrewbranch added this pull request to the merge queue Apr 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2025
@andrewbranch andrewbranch added this pull request to the merge queue Apr 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2025
@andrewbranch andrewbranch enabled auto-merge April 29, 2025 23:37
@andrewbranch andrewbranch added this pull request to the merge queue Apr 30, 2025
Merged via the queue into microsoft:main with commit 54aed8f Apr 30, 2025
23 checks passed
@andrewbranch andrewbranch deleted the extension-switching branch April 30, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants