Modify setup-go cache key to work better with merge queues #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Mar 7, 2025
Comment on lines
+28
to
+30
| key: ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}-${{ github.workflow }}-${{ inputs.cache-name }} | ||
| restore-keys: | | ||
| ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }} |
There was a problem hiding this comment.
The difference between these two now is that the step is allowed to restore the cache from another workflow.
This is technically "bad" because the space used may increase over time, but hopefully the cache will be invalidated by us changing the hashed files over time. Easy to change later, though, or only enable this sort of cache reuse in the merge queue.
RyanCavanaugh
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge queues work by creating a new branch on the repo to run CI on. Unfortunately, the caches are not shared between branches, so CI is always slower there than needed.
But, GHA can restore caches that come from
main; this normally works, but the cache key I set up for oursetup-goaction was scoped per workflow, so we'd never grab it from say, the main CI build.Reconfigure this to try and restore caches a bit more.