Extract Evaluator and NameResolver out of checker
#229
Conversation
| } | ||
| } | ||
|
|
||
| func (r *NameResolver) ResolveEntityName(name *ast.Node, meaning ast.SymbolFlags, ignoreErrors bool, dontResolveAlias bool, location *ast.Node) *ast.Symbol { |
There was a problem hiding this comment.
Just skimming this again; this is something that isn't present on the NameResolver in the old compiler; is there some difference here that makes this something that should move? I see it referenced in the constant evaluator, but the evaluator in the old compiler doesn't seem to require it.
(More or less, it seems like there's more moving than we previously had which I'm trying to understand)
There was a problem hiding this comment.
As I mentioned in the PR description, I'm extracting related functionality that enum emit depends on from the checker, resolveEntityName is used by resolveEntity, which is critical to the constant evaluator. Rather than duplicate resolveEntity in the checker and the enum transform, I opted to extract resolveEntity out of checker and centralize it within the new ConstantEvaluator type.
I've opted to do that in this PR instead of the enum emit PR to make both PRs easier to reason over.
|
Closing in favor of the more limited |
To better support enum emit without relying on the type checker, this moves
NameResolverand related functionality from thecompilerpackage to thebinderpackage, and extractsEvaluatorand related functionality into a newevaluatorpackage.