Skip to content

Pool sourceMapState tool #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Pool sourceMapState tool #1320

merged 1 commit into from
Jun 30, 2025
+7 −2

Conversation

jakebailey
Copy link
Member

Realized that I missed this in #1286.

@jakebailey jakebailey requested a review from weswigham June 30, 2025 16:13
weswigham
weswigham approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this probably could be by-value, we probably just need to pick a nonzero sentinel value for the early return. A TextRange with pos/end -2 could work pretty well, imo.

@jakebailey
Copy link
Member Author

I'll start with this and send the value change separately.

@jakebailey jakebailey added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit dbe69bd Jun 30, 2025
22 checks passed
@jakebailey jakebailey deleted the jabaile/source-map-state-pool branch June 30, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebailey @weswigham