Skip to content

Pool commentState allocations #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
+5 −2
Merged

Pool commentState allocations #1286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions internal/printer/printer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ type Printer struct {
inExtends bool // whether we are emitting the `extends` clause of a ConditionalType or InferType
nameGenerator NameGenerator
makeFileLevelOptimisticUniqueName func(string) string
commentStatePool core.Pool[commentState]
}

type detachedCommentsInfo struct {
Expand Down Expand Up @@ -4993,7 +4994,9 @@ func (p *Printer) emitCommentsBeforeNode(node *ast.Node) *commentState {
p.commentsDisabled = true
}

return &commentState{emitFlags, commentRange, containerPos, containerEnd, declarationListContainerEnd}
c := p.commentStatePool.New()
*c = commentState{emitFlags, commentRange, containerPos, containerEnd, declarationListContainerEnd}
return c
}

func (p *Printer) emitCommentsAfterNode(node *ast.Node, state *commentState) {
Expand Down Expand Up @@ -5046,7 +5049,7 @@ func (p *Printer) emitCommentsBeforeToken(token ast.Kind, pos int, contextNode *
p.decreaseIndentIf(needsIndent)
}

return &commentState{}, pos
return p.commentStatePool.New(), pos
}

func (p *Printer) emitCommentsAfterToken(token ast.Kind, pos int, contextNode *ast.Node, state *commentState) {
Expand Down