Skip to content

Fix: No error when assigning to getter-only static class property from another file #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix: No error when assigning to getter-only static class property from another file #1095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a07c9
Initial plan for issue
Copilot Jun 7, 2025
ddf8313
Fix: Check readonly properties for simple assignments across modules
Copilot Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12165,6 +12165,9 @@ func (c *Checker) checkAssignmentOperator(left *ast.Node, operator ast.Kind, rig
// getters can be a subtype of setters, so to check for assignability we use the setter's type instead
if isCompoundAssignment(operator) && ast.IsPropertyAccessExpression(left) {
leftType = c.checkPropertyAccessExpression(left, CheckModeNormal, true /*writeOnly*/)
} else if operator == ast.KindEqualsToken && ast.IsPropertyAccessExpression(left) {
// For simple assignments to property access expressions, check for readonly properties
c.checkPropertyAccessExpression(left, CheckModeNormal, true /*writeOnly*/)
}
if c.checkReferenceExpression(left, diagnostics.The_left_hand_side_of_an_assignment_expression_must_be_a_variable_or_a_property_access, diagnostics.The_left_hand_side_of_an_assignment_expression_may_not_be_an_optional_property_access) {
var headMessage *diagnostics.Message
Expand Down Expand Up @@ -25941,7 +25944,10 @@ func (c *Checker) isAssignmentToReadonlyEntity(expr *ast.Node, symbol *ast.Symbo
// references through namespace import should be readonly
if expressionSymbol.Flags&ast.SymbolFlagsAlias != 0 {
declaration := c.getDeclarationOfAliasSymbol(expressionSymbol)
return declaration != nil && ast.IsNamespaceImport(declaration)
if declaration != nil && ast.IsNamespaceImport(declaration) {
return true
}
// For other types of aliases (named imports), continue to check the target symbol
}
}
}
Expand Down