Skip to content

Fix generating module specifiers verbatim from exports #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewbranch
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andrewbranch Andrew Branch
@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 21:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the generation of module specifiers to use the paths defined in package exports verbatim, and updates the corresponding baseline tests and declaration outputs to match the new behavior.

  • Adjusts tryGetModuleNameAsNodeModule to return the proper moduleFileToTry when using verbatim exports.
  • Updates baseline error, type, and JS outputs for node16, node18, and nodenext scenarios to remove explicit node_modules paths and redundant TS2742 errors.
  • Fixes bundler condition declaration emit to produce accurate import specifiers.

Reviewed Changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/modulespecifiers/specifiers.go Return moduleFileToTry for verbatim exports
testdata/baselines/reference/submodule/conformance/nodeModulesExportsSpecifierGenerationConditions(module=node18).errors.txt Remove TS2742 error and update error count
testdata/baselines/reference/submodule/conformance/nodeModulesExportsSpecifierGenerationConditions(module=node16).types.diff Change import specifiers in type baseline
testdata/baselines/reference/submodule/conformance/nodeModulesExportsSpecifierGenerationConditions(module=node16).types Change import specifiers in type baseline
testdata/baselines/reference/submodule/conformance/nodeModulesExportsSpecifierGenerationConditions(module=node16).js.diff Remove outdated declaration baseline
testdata/baselines/reference/submodule/conformance/nodeModulesExportsSpecifierGenerationConditions(module=node16).js Restore correct declaration import
testdata/baselines/reference/submodule/conformance/nodeModulesExportsSpecifierGenerationConditions(module=node16).errors.txt.diff Remove duplicate error baseline
testdata/baselines/reference/submodule/conformance/nodeModulesExportsSpecifierGenerationConditions(module=node16).errors.txt Remove TS2742 error
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=nodenext).types.diff Update nodenext dynamic import type outputs
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=nodenext).types Update nodenext dynamic import type outputs
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=nodenext).js.diff Fix nodenext declaration emit with resolution-mode imports
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=nodenext).js Remove unnecessary resolution-mode option in declaration outputs
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=node18).types.diff Update node18 dynamic import type outputs
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=node18).types Update node18 dynamic import type outputs
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=node18).js.diff Fix node18 declaration emit formatting
testdata/baselines/reference/submodule/conformance/nodeModulesDeclarationEmitDynamicImportWithPackageExports(module=node18).js Remove resolution-mode option for node18 declarations
testdata/baselines/reference/submodule/compiler/declarationEmitBundlerConditions.js.diff Update bundler conditions declaration baseline
testdata/baselines/reference/submodule/compiler/declarationEmitBundlerConditions.js Restore correct import("pkg").C specifier
testdata/baselines/reference/submodule/compiler/declarationEmitBundlerConditions.errors.txt.diff Remove obsolete TS2742 error baseline
testdata/baselines/reference/submodule/compiler/declarationEmitBundlerConditions.errors.txt Clear out TS2742 error

@RyanCavanaugh RyanCavanaugh added this pull request to the merge queue Jun 6, 2025
Merged via the queue into microsoft:main with commit 63d6b11 Jun 6, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants