Move version from source file to document registry
#1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR relocates version tracking from the AST SourceFile itself into the central DocumentRegistry to prevent data races when caching source files.
- Replaces direct
SourceFile.Versionchecks with a registry-backedgetFileVersionlookup insnapshotandprintlogic - Adds a
versionfield toregistryEntryand updates it whenever a new parse occurs - Removes the now-unneeded
Versionfield fromast.SourceFile
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/project/project.go | Switched version comparisons to use getFileVersion and added a proxy method on Project |
| internal/project/documentregistry.go | Introduced version in registryEntry, updated parsing logic, and added getFileVersion |
| internal/ast/ast.go | Removed the deprecated Version field from SourceFile |
Comments suppressed due to low confidence (2)
internal/project/documentregistry.go:122
- New
getFileVersionlogic inDocumentRegistrylacks unit tests to ensure it correctly retrieves the stored version (and returns -1 when missing).
func (r *DocumentRegistry) getFileVersion(file *ast.SourceFile, options *core.CompilerOptions) int {
internal/project/project.go:1033
- The proxy
Project.getFileVersionmethod is untested; consider adding tests to validate it correctly delegates to the registry.
func (p *Project) getFileVersion(file *ast.SourceFile, options *core.CompilerOptions) int {
jakebailey
reviewed
Jun 5, 2025
gabritto
changed the title
version from source file to document registry
Merged
sheetalkamat
approved these changes
Jun 6, 2025
sheetalkamat
previously requested changes
Jun 6, 2025
| func (r *DocumentRegistry) getFileVersion(file *ast.SourceFile, options *core.CompilerOptions) int { | ||
| key := newRegistryKey(options, file.Path(), file.ScriptKind) | ||
| if entry, ok := r.documents.Load(key); ok { | ||
| return entry.version |
There was a problem hiding this comment.
This is not enough i think. The source file may have been updated for the compilerOptions by other program and hence the source file may be newer = script info version. You actually want to check if file == entry.sourceFile as well
andrewbranch
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version really only concerns the project and document registry, so I moved it there to avoid a data race in #991 where we cache
SourceFiles.