Measure config parse / file scan time, actual total time #1069
+36
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Strada, I can't tell if this time was omitted or just a part of the parse time (probably the latter). But we were totally omitting it in this repo, which hides the fact that config loading and file scanning takes a significant amount of time. Collect this number, and then ensure the total time actually includes everything.
See: #1062 (comment)
This is going to make our total time stat longer, but it's more realistic, and we should totally go and optimize file scanning/matching to eliminate the use of
regexp2
.As part of this, I've refactored
System
such that time fully goes throughSystem
, which I mistakenly did not do in my original PR moving this functionality into theexecute
pacakge.