Skip to content

Port "Lookup non-local element factory for reference marking when marking fragment references" #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Jun 5, 2025

…king fragment references"

Co-authored-by: Wesley Wigham <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings June 5, 2025 13:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports changes from the referenced TypeScript pull request by updating the logic for marking JSX factory references in fragments while simultaneously removing obsolete error baselines.

  • Updated error baseline files to remove expectations for the unused 'element' error.
  • Modified the JSX fragment reference marking logic to use the result of getJsxFactoryEntity instead of the prior local namespace.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
testdata/baselines/reference/submodule/compiler/jsxFragmentAndFactoryUsedOnFragmentUse.errors.txt.diff Removed outdated baseline error output.
testdata/baselines/reference/submodule/compiler/jsxFragmentAndFactoryUsedOnFragmentUse.errors.txt Removed outdated baseline error output.
internal/checker/checker.go Updated logic to mark JSX fragment references via getJsxFactoryEntity.
Comments suppressed due to low confidence (1)

internal/checker/checker.go:26971

  • Consider verifying that ast.GetFirstIdentifier(entity) always returns a non-nil identifier or add a guard/documentation to clarify that a nil result is not possible, thereby ensuring robust handling of edge cases.
localJsxNamespace := ast.GetFirstIdentifier(entity).Text()

@jakebailey jakebailey added this pull request to the merge queue Jun 5, 2025
Merged via the queue into microsoft:main with commit 04fae66 Jun 5, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants