Skip to content

fix(949): fix unmatched closing tags in JSX with referenced identifiers #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix(949): fix unmatched closing tags in JSX with referenced identifiers #1056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/transformers/utilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ func isIdentifierReference(name *ast.IdentifierNode, parent *ast.Node) bool {
return parent.AsImportAttribute().Value == name
case ast.KindJsxOpeningElement:
return parent.AsJsxOpeningElement().TagName == name
case ast.KindJsxClosingElement:
return parent.AsJsxClosingElement().TagName == name
default:
return false
}
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/conformance/inlineJsxFactoryDeclarations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
exports.prerendered = void 0;
/** @jsx h */
const renderer_1 = require("./renderer");
exports.prerendered = <renderer_1.dom></h>;
exports.prerendered = <renderer_1.dom></renderer_1.dom>;
//// [othernoalias.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/conformance/inlineJsxFactoryDeclarations.js.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
-var renderer_1 = require("./renderer");
-exports.prerendered = (0, renderer_1.dom)("h", null);
+const renderer_1 = require("./renderer");
+exports.prerendered = <renderer_1.dom></h>;
+exports.prerendered = <renderer_1.dom></renderer_1.dom>;
//// [othernoalias.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Expand Down
4 changes: 2 additions & 2 deletions testdata/baselines/reference/submodule/conformance/inlineJsxFactoryDeclarationsLocalTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class MyClass {
}
}
exports.MyClass = MyClass;
exports.tree = <exports.MySFC x={1} y={2}><MyClass x={3} y={4}/><MyClass x={5} y={6}/></MySFC>;
exports.tree = <exports.MySFC x={1} y={2}><MyClass x={3} y={4}/><MyClass x={5} y={6}/></exports.MySFC>;
exports.default = <h></h>;
//// [index.js]
"use strict";
Expand All @@ -133,6 +133,6 @@ class DOMClass {
// Should work, everything is a DOM element
const _tree = <DOMSFC x={1} y={2}><DOMClass x={3} y={4}/><DOMClass x={5} y={6}/></DOMSFC>;
// Should fail, no dom elements
const _brokenTree = <component_1.MySFC x={1} y={2}><component_1.MyClass x={3} y={4}/><component_1.MyClass x={5} y={6}/></MySFC>;
const _brokenTree = <component_1.MySFC x={1} y={2}><component_1.MyClass x={3} y={4}/><component_1.MyClass x={5} y={6}/></component_1.MySFC>;
// Should fail, nondom isn't allowed as children of dom
const _brokenTree2 = <DOMSFC x={1} y={2}>{component_1.tree}{component_1.tree}</DOMSFC>;
4 changes: 2 additions & 2 deletions .../baselines/reference/submodule/conformance/inlineJsxFactoryDeclarationsLocalTypes.js.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
- (0, renderer2_1.predom)(MyClass, { x: 3, y: 4 }),
- (0, renderer2_1.predom)(MyClass, { x: 5, y: 6 }));
-exports.default = (0, renderer2_1.predom)("h", null);
+exports.tree = <exports.MySFC x={1} y={2}><MyClass x={3} y={4}/><MyClass x={5} y={6}/></MySFC>;
+exports.tree = <exports.MySFC x={1} y={2}><MyClass x={3} y={4}/><MyClass x={5} y={6}/></exports.MySFC>;
+exports.default = <h></h>;
//// [index.js]
"use strict";
Expand Down Expand Up @@ -116,7 +116,7 @@
-var _brokenTree = (0, renderer_1.dom)(component_1.MySFC, { x: 1, y: 2 },
- (0, renderer_1.dom)(component_1.MyClass, { x: 3, y: 4 }),
- (0, renderer_1.dom)(component_1.MyClass, { x: 5, y: 6 }));
+const _brokenTree = <component_1.MySFC x={1} y={2}><component_1.MyClass x={3} y={4}/><component_1.MyClass x={5} y={6}/></MySFC>;
+const _brokenTree = <component_1.MySFC x={1} y={2}><component_1.MyClass x={3} y={4}/><component_1.MyClass x={5} y={6}/></component_1.MySFC>;
// Should fail, nondom isn't allowed as children of dom
-var _brokenTree2 = (0, renderer_1.dom)(DOMSFC, { x: 1, y: 2 },
- component_1.tree,
Expand Down