Skip to content

Untyped, side-effect imports treated differently in Strada vs Corsa #920

Closed
@nirrek

Description

@nirrek

We have a side-effect import of an untyped module

import 'videojs-http-source-selector';

Strada doesn't produce any type errors, presumably since no symbols are imported it doesn't care that type information can't be found.

Corsa, on the other hand, produces the following type error:

error TS2307: Cannot find module 'videojs-http-source-selector' or its corresponding type declarations.

This is trivial to fix with a simple .d.ts like this:

declare module 'videojs-http-source-selector';

Not a big issue if Corsa behaviour diverges here imo, but thought I would point out that there is a behavioural difference that means that Corsa won't be a drop-in-replacement for codebases with these types of imports.

Activity

jakebailey

jakebailey commented on May 23, 2025

@jakebailey
Member

It's just a bug; this part of the code is likely being fixed in #851

jakebailey

jakebailey commented on Jun 4, 2025

@jakebailey
Member

This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: Type CheckingRelated to type checking, grammar checking

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @nirrek@jakebailey

        Issue actions

          Untyped, side-effect imports treated differently in Strada vs Corsa · Issue #920 · microsoft/typescript-go