Closed
Description
We have a side-effect import of an untyped module
import 'videojs-http-source-selector';
Strada doesn't produce any type errors, presumably since no symbols are imported it doesn't care that type information can't be found.
Corsa, on the other hand, produces the following type error:
error TS2307: Cannot find module 'videojs-http-source-selector' or its corresponding type declarations.
This is trivial to fix with a simple .d.ts like this:
declare module 'videojs-http-source-selector';
Not a big issue if Corsa behaviour diverges here imo, but thought I would point out that there is a behavioural difference that means that Corsa won't be a drop-in-replacement for codebases with these types of imports.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
jakebailey commentedon May 23, 2025
It's just a bug; this part of the code is likely being fixed in #851
jakebailey commentedon Jun 4, 2025
This is fixed.