Skip to content

linked (local) dependencies are not skipped #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophe-g opened this issue Apr 29, 2025 · 0 comments
Open

linked (local) dependencies are not skipped #836

christophe-g opened this issue Apr 29, 2025 · 0 comments

Comments

@christophe-g
Copy link

With tsconfig skipLibCheck set to true, the compiler should not check the types of linked dependencies.

In this repo, we have a linked dependency:

  "dependencies": {
    "@vaadin/button": "file:../web-components/packages/button",
    "semver": "^7.7.1"
  }

Steps to reproduce

This results in the following error:

../web-components/packages/button/src/vaadin-button-mixin.d.ts:6:34 - error TS2307: Cannot find module '@open-wc/dedupe-mixin' or its corresponding type declarations.

6 import type { Constructor } from '@open-wc/dedupe-mixin';
                                   ~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button-mixin.d.ts:7:39 - error TS2307: Cannot find module '@vaadin/a11y-base/src/active-mixin.js' or its corresponding type declarations.

7 import type { ActiveMixinClass } from '@vaadin/a11y-base/src/active-mixin.js';
                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button-mixin.d.ts:8:41 - error TS2307: Cannot find module '@vaadin/a11y-base/src/disabled-mixin.js' or its corresponding type declarations.

8 import type { DisabledMixinClass } from '@vaadin/a11y-base/src/disabled-mixin.js';
                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button-mixin.d.ts:9:38 - error TS2307: Cannot find module '@vaadin/a11y-base/src/focus-mixin.js' or its corresponding type declarations.

9 import type { FocusMixinClass } from '@vaadin/a11y-base/src/focus-mixin.js';
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button-mixin.d.ts:10:41 - error TS2307: Cannot find module '@vaadin/a11y-base/src/keyboard-mixin.js' or its corresponding type declarations.

10 import type { KeyboardMixinClass } from '@vaadin/a11y-base/src/keyboard-mixin.js';
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button-mixin.d.ts:11:41 - error TS2307: Cannot find module '@vaadin/a11y-base/src/tabindex-mixin.js' or its corresponding type declarations.

11 import type { TabindexMixinClass } from '@vaadin/a11y-base/src/tabindex-mixin.js';
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button.d.ts:6:33 - error TS2307: Cannot find module '@vaadin/component-base/src/controller-mixin.js' or its corresponding type declarations.

6 import { ControllerMixin } from '@vaadin/component-base/src/controller-mixin.js';
                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button.d.ts:7:30 - error TS2307: Cannot find module '@vaadin/component-base/src/element-mixin.js' or its corresponding type declarations.

7 import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js';
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../web-components/packages/button/src/vaadin-button.d.ts:8:31 - error TS2307: Cannot find module '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js' or its corresponding type declarations.

8 import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 9 errors in 2 files.

Errors  Files
     6  ../web-components/packages/button/src/vaadin-button-mixin.d.ts:6
     3  ../web-components/packages/button/src/vaadin-button.d.ts:6

Expected behavior

like tsc, linked dependencies should not be checked with the flag --skipLibCheck (or skipLibCheck in tsconfig.json).

@christophe-g christophe-g changed the title linked (local) dependencies are not skiped linked (local) dependencies are not skipped Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant